torkell | Slightly improved file uploader (Reply)

Anyway, enough ranting about nutters on the road. Remember the file uploader I hacked together earlier this year? Well, I discovered a slight flaw when using it with the Wii U - the filename provided by the console is static, and so later uploads overwrite earlier ones. That's easily fixed...

<?php

function title() {
  return '/' . $_SERVER['SERVER_NAME'] . '/' . $_REQUEST['path'];
}

if (isset($_REQUEST['path']) && $_REQUEST['path'] != '') {
  $sPrefix = $_REQUEST['path'] . '/';
  chdir(getcwd() . '/' . $_REQUEST['path']);
}

?>

<!DOCTYPE HTML>
<HTML>
<HEAD>
<TITLE><?=title() ?></TITLE>
</HEAD>
<BODY>
<H1><?=title() ?></H1>

<?php

if (isset($_REQUEST['upload'])) {
  for ($i = 0; $i < count($_FILES['file']['name']); $i++) {
    if ($_FILES['file']['error'][$i] != UPLOAD_ERR_OK) {
      echo '<P style="font-weight: bold; color: red;">Upload error on <TT>' . $_FILES['file']['name'][$i]
         . '</TT>: ' . $_FILES['file']['error'][$i] . '</P>';
    } else {
      $pathinfo = pathinfo($_FILES['file']['name'][$i]);
      $dest = $pathinfo['filename'] . strftime('-%Y%m%d-%H%M%S.') . $pathinfo['extension'];
      move_uploaded_file($_FILES['file']['tmp_name'][$i], $dest);
      echo '<P style="font-weight: bold; color: darkgreen;">Uploaded <tt>' . $_FILES['file']['name'][$i] . '</TT> as <TT>' . $dest . '</TT></P>';
    }
  }
}

if (isset($_REQUEST['mkdir'])) {
  mkdir($_REQUEST['dir']);
}

?>

<FORM action="<?=$_SERVER['PHP_SELF'] ?>" method="post" enctype="multipart/form-data">
<INPUT type="hidden" name="path" value="<?=$_REQUEST['path'] ?>">
<P><LABEL for="file">Upload here:</LABEL> <INPUT type="file" name="file[]" id="file" multiple>
<INPUT type="submit" name="upload" value="Upload"></P>
</FORM>

<FORM action="<?=$_SERVER['PHP_SELF'] ?>" method="post" enctype="multipart/form-data">
<INPUT type="hidden" name="path" value="<?=$_REQUEST['path'] ?>">
<P><LABEL for="dir">Create directory:</LABEL> <INPUT type="text" name="dir" id="dir">
<INPUT type="submit" name="mkdir" value="Create"></P>
</FORM>

<TABLE>
<TR>
<TH>Type</TH>
<TH>File</TH>
<TH>Size</TH>
</TR>

<?php

$hDir = opendir('.');
while (($sFile = readdir($hDir)) !== FALSE) {
  if ($sFile == '.' || $sFile == '..') {
    continue;
  }

  echo '<TR>';
  if (is_file($sFile)) {
    $aFile = stat($sFile);
    echo '<TD>File</TD>';
    echo '<TD><A href="' . $sPrefix . $sFile . '">' . $sFile . '</A></TD>';
    echo '<TD>' . $aFile[7] . '</TD>';
  } else if (is_dir($sFile)) {
    echo '<TD>Dir</TD>';
    echo '<TD><A href="' . $_SERVER['PHP_SELF'] . '?path=' . urlencode($sPrefix . $sFile) . '">' . $sFile . '</A></TD>';
    echo '<TD></TD>';
  }
  echo '</TR>';
}
closedir($hDir);

?>

</TABLE>
</BODY>
</HTML>

The change is only a few lines - the call to move_uploaded_file has been replaced with

      $pathinfo = pathinfo($_FILES['file']['name'][$i]);
      $dest = $pathinfo['filename'] . strftime('-%Y%m%d-%H%M%S.') . $pathinfo['extension'];
      move_uploaded_file($_FILES['file']['tmp_name'][$i], $dest);

The result is each uploaded file has the current date and time appended to it (for example, vorpal.jpeg becomes vorpal-20141120-205045.jpeg). Obviously this will still overwrite files if you manage to upload the same filename multiple times within the same second, to which my answer is meh! As before, feel free to use it under the 3-clause BSD license.